refactor: remove deprecated result types and compat shims#157
Open
jsonbailey wants to merge 1 commit intomainfrom
Open
refactor: remove deprecated result types and compat shims#157jsonbailey wants to merge 1 commit intomainfrom
jsonbailey wants to merge 1 commit intomainfrom
Conversation
jsonbailey
force-pushed
the
jb/aic-2388/langchain-runner-protocol
branch
from
9c0003c to
1aa1069
Compare
jsonbailey
force-pushed
the
jb/aic-2388/remove-deprecated-types
branch
from
4966c51 to
1b3a1ba
Compare
jsonbailey
force-pushed
the
jb/aic-2388/langchain-runner-protocol
branch
from
1aa1069 to
f811cf8
Compare
jsonbailey
force-pushed
the
jb/aic-2388/remove-deprecated-types
branch
from
1b3a1ba to
cd04edb
Compare
jsonbailey
force-pushed
the
jb/aic-2388/langchain-runner-protocol
branch
from
f811cf8 to
e56ea8f
Compare
jsonbailey
force-pushed
the
jb/aic-2388/remove-deprecated-types
branch
from
cd04edb to
de96fcd
Compare
jsonbailey
force-pushed
the
jb/aic-2388/langchain-runner-protocol
branch
from
e56ea8f to
4e0b78d
Compare
jsonbailey
force-pushed
the
jb/aic-2388/remove-deprecated-types
branch
from
de96fcd to
33bcaa7
Compare
jsonbailey
force-pushed
the
jb/aic-2388/langchain-runner-protocol
branch
from
4e0b78d to
c1c2c8c
Compare
jsonbailey
force-pushed
the
jb/aic-2388/remove-deprecated-types
branch
from
33bcaa7 to
bccb5bc
Compare
jsonbailey
force-pushed
the
jb/aic-2388/langchain-runner-protocol
branch
from
c1c2c8c to
a233c2f
Compare
jsonbailey
force-pushed
the
jb/aic-2388/remove-deprecated-types
branch
from
bccb5bc to
c2d054f
Compare
jsonbailey
force-pushed
the
jb/aic-2388/langchain-runner-protocol
branch
from
a233c2f to
a770b1f
Compare
jsonbailey
force-pushed
the
jb/aic-2388/remove-deprecated-types
branch
from
c2d054f to
c083c3d
Compare
jsonbailey
force-pushed
the
jb/aic-2388/langchain-runner-protocol
branch
from
a770b1f to
069c0ee
Compare
jsonbailey
force-pushed
the
jb/aic-2388/remove-deprecated-types
branch
from
c083c3d to
f0c6494
Compare
jsonbailey
force-pushed
the
jb/aic-2388/langchain-runner-protocol
branch
from
069c0ee to
1c0255f
Compare
jsonbailey
force-pushed
the
jb/aic-2388/remove-deprecated-types
branch
from
f0c6494 to
769815c
Compare
jsonbailey
force-pushed
the
jb/aic-2388/langchain-runner-protocol
branch
from
1c0255f to
0355872
Compare
jsonbailey
force-pushed
the
jb/aic-2388/remove-deprecated-types
branch
from
769815c to
19e344d
Compare
jsonbailey
force-pushed
the
jb/aic-2388/langchain-runner-protocol
branch
from
0355872 to
796bda5
Compare
jsonbailey
force-pushed
the
jb/aic-2388/remove-deprecated-types
branch
from
19e344d to
0374773
Compare
jsonbailey
force-pushed
the
jb/aic-2388/langchain-runner-protocol
branch
from
796bda5 to
a2db8cb
Compare
jsonbailey
force-pushed
the
jb/aic-2388/remove-deprecated-types
branch
from
0374773 to
6677156
Compare
jsonbailey
force-pushed
the
jb/aic-2388/langchain-runner-protocol
branch
4 times, most recently
from
7aae3e2 to
1e61d42
Compare
jsonbailey
force-pushed
the
jb/aic-2388/remove-deprecated-types
branch
from
6677156 to
3867b8f
Compare
…esult and compat shims
jsonbailey
force-pushed
the
jb/aic-2388/remove-deprecated-types
branch
from
3867b8f to
87007b9
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 87007b9. Configure here.
| :param messages: Array of LDMessage objects representing the conversation | ||
| :return: ModelResponse containing the model's response and metrics | ||
| """ | ||
| ... |
There was a problem hiding this comment.
ModelRunner protocol is dead code after migration
Low Severity
The ModelRunner protocol defines invoke_model but nothing in the codebase calls this method or type-checks against this protocol. Both OpenAIModelRunner and LangChainModelRunner implement Runner (with its run method), not ModelRunner. The managed layer exclusively uses Runner. Implementing ModelRunner alone would not satisfy the Runner protocol the SDK requires, making this export misleading and effectively dead code that outlived its purpose during the migration.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 87007b9. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the deprecated result types (
ModelResponse,StructuredResponse,AgentResult) and associated compat shims now that all runner implementations have migrated to theRunnerprotocol.Stacked on #150 (LangChain runner migration).
Changes
ModelResponse,StructuredResponse,AgentResultfromproviders/types.pyModelRunner-related compat frommanaged_model.pyandmanaged_agent.pyai_provider.pyandmodel_runner.py🤖 Generated with Claude Code
Note
Medium Risk
Medium risk because this removes deprecated public types/exports and changes protocol return types (
ModelRunner/AgentRunner) toRunnerResult, which can break downstream imports and provider implementations.Overview
Removes the deprecated response/result dataclasses
ModelResponse,StructuredResponse, andAgentResultand drops their re-exports fromldai/ldai.providers.Unifies runner protocols around
RunnerResult:AgentRunner.run()andModelRunner.invoke_model()now returnRunnerResult, andAIProviderno longer includes legacyinvoke_model/invoke_structured_modelshims;ManagedModelis updated to type the tracked run result asRunnerResult.Reviewed by Cursor Bugbot for commit 87007b9. Bugbot is set up for automated code reviews on this repo. Configure here.